Support Gradle to 9.4, AGP 9.1, Kotlin 2.3, Java 26#56222
Support Gradle to 9.4, AGP 9.1, Kotlin 2.3, Java 26#56222leotm wants to merge 1 commit intofacebook:mainfrom
Conversation
58dc716 to
eada3f9
Compare
|
Gradle 9.4.0 -> 9.4.1 Also agp 9.2 require at least 9.5.x so if this is not so urget it can wait until 9.5.x series became stable ( Right now it is https://github.com/gradle/gradle/releases/tag/v9.5.0-RC1 ) |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
9a017c2 to
53c90d6
Compare
|
It looks like this is just a AI hallucination PR KotlinVersion.KOTLIN_2_3 doesn't even supported in grade 9.4.1 also seen some parts just added like try to fix without logic. Meta should put a STRICT forbidding rules for any kind of AI agent helped PRs . |
|
NB: CI errors resolved via re-runs linthttps://github.com/facebook/react-native/actions/runs/24193792111/job/70617965386 test_e2e_android_rntester (release)https://github.com/facebook/react-native/actions/runs/24410144484/job/71309405314 run_fantom_tests failedhttps://github.com/facebook/react-native/actions/runs/24410228534/job/71306995339 |
|
thanks for the comments @usta
this is factually incorrect by this logic, main branch - Gradle 9.3.1, KGP 2.1.20, apiVersion KOTLIN_1_8, AGP 8.12.0 the Gradle compat matrix says nothing about KotlinVersion constants derived from KGP source code KotlinVersion.KOTLIN_2_3 exists the compat matrix states Gradle 9.4.1 embeds Kotlin 2.3.0 compiler that evals build.gradle.kts files on 2.2 syntax "Gradle is tested with Kotlin 2.0.0 through 2.3.20-Beta1" shows KGP 2.3 can compile .kt source files RNGP's bundled KGP apiVersion KOTLIN_2_3 value is a binary compat marker encoded in bytecode when the JAR gets compiled, it has nothing to do with Gradle's Kotlin defaults
no, each DSL migration is a trivial documented AGP 9+ change
AGP 9.2 defaults to minimum Gradle is 9.4.1, not 9.5.x
editing this out then claiming KOTLIN_2_3 isn't supported, I don't follow the reasoning
you've been subscribed to the PR, iterated on over a month, each Android CI failure fixed incrementally |
d430adf to
5d090b8
Compare
Summary:
Follow-up to
finalizeDslas the DSL finalization blocks have already been executed. In particular, you cannot callfinalizeDslwithin thebeforeVariantsoronVariantsblocks. Instead, you must callfinalizeDsldirectly within theandroidComponentsblockTODO
NB: official Gradle 9.4 support in Kotlin 2.4.0-Beta2 (April 22, 2026)
TODO: split into incremental atomic PRs to accomplish Java 26 build time support
Changelog:
[ANDROID] [CHANGED] - Upgradle to Gradle 9.4, Kotlin 2.3, AGP 9.1 and support Java 26
Test Plan:
.\gradlew .\gradlew :private:react-native-fantom:buildFantomTesterlocally on 0.16.0 tarball 404